Antoine Deschênes 9876bb2bd9 fix(pop3): track STLS state per session instead of per server (#626) ...

The TLS connection state lived on the shared POP3 Server, and Session
reached it through its embedded *Server.  Once any client completed
STLS, every later session saw a non-nil state: CAPA stopped advertising
STLS and the STLS command returned "-ERR A TLS session already agreed
upon." until the server restarted.  Sessions also wrote the shared field
concurrently without synchronization.

Move tlsState to Session.  ForceTLS sessions set it when the session
starts, and STLS sets it on the negotiating session only.

TestSTLSPerSession runs CAPA, STLS and a TLS handshake on two sessions of
one server; it fails against the previous code on the second session.

Signed-off-by: Antoine Deschênes <antoine@antoinedeschenes.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

2026-10-04 10:51:32 -07:00

..

handler_test.go

fix(pop3): track STLS state per session instead of per server (#626)

2026-10-04 10:51:32 -07:00

handler.go

fix(pop3): track STLS state per session instead of per server (#626)

2026-10-04 10:51:32 -07:00

listener.go

fix(pop3): track STLS state per session instead of per server (#626)

2026-10-04 10:51:32 -07:00

transaction_test.go

fix(pop3): reject deleted messages and failed TLS handshakes (#620)

2026-09-16 18:10:40 -07:00