Mirrors/kararas_iris
1
0
Fork 0
mirror of https://github.com/kataras/iris.git synced 2025-12-17 18:07:01 +00:00
Code Releases Activity

websocket disconnect/leave-all-rooms should delete empty rooms as well otherwise rooms hash goes ever growing

Browse Source 
Former-commit-id: 7f228be67cab79fc34f4a5a6a8b41b6ba8330186
This commit is contained in:
Akira Ho
2018-01-05 09:30:21 +08:00
parent 10714273e9
commit 5157ed17a6
1 changed files with 2 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
websocket/server.go
View File

@@ -259,17 +259,8 @@ func (s *Server) join(roomName string, connID string) {
// LeaveAll kicks out a connection from ALL of its joined rooms // LeaveAll kicks out a connection from ALL of its joined rooms
func (s *Server) LeaveAll(connID string) { func (s *Server) LeaveAll(connID string) {
s.mu.Lock() s.mu.Lock()
for name, connectionIDs := range s.rooms { for name, _ := range s.rooms {
for i := range connectionIDs { s.leave(name, connID)
if connectionIDs[i] == connID {
// fire the on room leave connection's listeners
s.connections.get(connID).fireOnLeave(name)
// the connection is inside this room, lets remove it
if i < len(s.rooms[name]) {
s.rooms[name] = append(s.rooms[name][:i], s.rooms[name][i+1:]...)
}
}
}
} }
s.mu.Unlock() s.mu.Unlock()
} }