ui: Display server uptime, scan completion time

pkg/storage/retention.go

@@ -3,7 +3,6 @@ package storage
 import (
 	"container/list"
 	"expvar"
-	"sync"
 	"time"
 
 	"github.com/jhillyerd/inbucket/pkg/config"
@@ -12,8 +11,7 @@ import (
 )
 
 var (
-	retentionScanCompleted   = time.Now()
-	retentionScanCompletedMu sync.RWMutex
+	scanCompletedMillis = new(expvar.Int)
 
 	// History counters
 	expRetentionDeletesTotal = new(expvar.Int)
@@ -34,7 +32,7 @@ var (
 
 func init() {
 	rm := expvar.NewMap("retention")
-	rm.Set("SecondsSinceScanCompleted", expvar.Func(secondsSinceRetentionScanCompleted))
+	rm.Set("ScanCompletedMillis", scanCompletedMillis)
 	rm.Set("DeletesHist", expRetentionDeletesHist)
 	rm.Set("DeletesTotal", expRetentionDeletesTotal)
 	rm.Set("Period", expRetentionPeriod)
@@ -159,7 +157,7 @@ func (rs *RetentionScanner) DoScan() error {
 		return err
 	}
 	// Update metrics
-	setRetentionScanCompleted(time.Now())
+	scanCompletedMillis.Set(time.Now().UnixNano() / 1000000)
 	expRetainedCurrent.Set(int64(retained))
 	expRetainedSize.Set(storeSize)
 	return nil
@@ -171,19 +169,3 @@ func (rs *RetentionScanner) Join() {
 		<-rs.retentionShutdown
 	}
 }
-
-func setRetentionScanCompleted(t time.Time) {
-	retentionScanCompletedMu.Lock()
-	defer retentionScanCompletedMu.Unlock()
-	retentionScanCompleted = t
-}
-
-func getRetentionScanCompleted() time.Time {
-	retentionScanCompletedMu.RLock()
-	defer retentionScanCompletedMu.RUnlock()
-	return retentionScanCompleted
-}
-
-func secondsSinceRetentionScanCompleted() interface{} {
-	return time.Since(getRetentionScanCompleted()) / time.Second
-}