1
0
mirror of https://github.com/jhillyerd/inbucket.git synced 2025-12-18 10:07:02 +00:00

ui: Refactor page view/framing to handle titles

This commit is contained in:
James Hillyerd
2018-11-18 10:37:57 -08:00
parent 59062e1326
commit eaf41949d4
7 changed files with 112 additions and 120 deletions

View File

@@ -255,10 +255,7 @@ setRoute route model =
Route.Status -> Route.Status ->
( { model | page = Status Status.init } ( { model | page = Status Status.init }
, Cmd.batch
[ Ports.windowTitle "Inbucket Status"
, Cmd.map StatusMsg Status.load , Cmd.map StatusMsg Status.load
]
, Session.none , Session.none
) )
in in
@@ -313,27 +310,30 @@ view model =
, recentActive = mailbox , recentActive = mailbox
} }
frame = framePage :
Page.frame controls model.session ActivePage
-> (msg -> Msg)
-> { title : String, content : Html msg }
-> Document Msg
framePage page toMsg { title, content } =
Document title
[ content
|> Html.map toMsg
|> Page.frame controls model.session page
]
in in
Document "Inbucket Document" case model.page of
[ case model.page of
Home subModel -> Home subModel ->
Html.map HomeMsg (Home.view model.session subModel) framePage Page.Other HomeMsg (Home.view model.session subModel)
|> frame Page.Other
Mailbox subModel -> Mailbox subModel ->
Html.map MailboxMsg (Mailbox.view model.session subModel) framePage Page.Mailbox MailboxMsg (Mailbox.view model.session subModel)
|> frame Page.Mailbox
Monitor subModel -> Monitor subModel ->
Html.map MonitorMsg (Monitor.view model.session subModel) framePage Page.Monitor MonitorMsg (Monitor.view model.session subModel)
|> frame Page.Monitor
Status subModel -> Status subModel ->
Html.map StatusMsg (Status.view model.session subModel) framePage Page.Status StatusMsg (Status.view model.session subModel)
|> frame Page.Status
]

View File

@@ -19,12 +19,7 @@ type alias Model =
init : ( Model, Cmd Msg ) init : ( Model, Cmd Msg )
init = init =
( Model "" ( Model "", cmdGreeting )
, Cmd.batch
[ Ports.windowTitle "Inbucket"
, cmdGreeting
]
)
cmdGreeting : Cmd Msg cmdGreeting : Cmd Msg
@@ -57,8 +52,10 @@ update session msg model =
-- VIEW -- -- VIEW --
view : Session -> Model -> Html Msg view : Session -> Model -> { title : String, content : Html Msg }
view session model = view session model =
{ title = "Inbucket"
, content =
div [ id "page" ] div [ id "page" ]
[ Html.node "rendered-html" [ Html.node "rendered-html"
[ class "greeting" [ class "greeting"
@@ -66,3 +63,4 @@ view session model =
] ]
[] []
] ]
}

View File

@@ -87,8 +87,7 @@ init mailboxName selection =
load : String -> Cmd Msg load : String -> Cmd Msg
load mailboxName = load mailboxName =
Cmd.batch Cmd.batch
[ Ports.windowTitle (mailboxName ++ " - Inbucket") [ Task.perform Tick Time.now
, Task.perform Tick Time.now
, getList mailboxName , getList mailboxName
] ]
@@ -463,8 +462,10 @@ getMessage mailboxName id =
-- VIEW -- VIEW
view : Session -> Model -> Html Msg view : Session -> Model -> { title : String, content : Html Msg }
view session model = view session model =
{ title = model.mailboxName ++ " - Inbucket"
, content =
div [ id "page", class "mailbox" ] div [ id "page", class "mailbox" ]
[ viewMessageList session model [ viewMessageList session model
, main_ , main_
@@ -486,6 +487,7 @@ view session model =
text "" text ""
] ]
] ]
}
viewMessageList : Session -> Model -> Html Msg viewMessageList : Session -> Model -> Html Msg

View File

@@ -32,12 +32,7 @@ type alias Model =
init : ( Model, Cmd Msg ) init : ( Model, Cmd Msg )
init = init =
( Model False [] ( Model False [], Ports.monitorCommand True )
, Cmd.batch
[ Ports.windowTitle "Inbucket Monitor"
, Ports.monitorCommand True
]
)
@@ -95,8 +90,10 @@ update session msg model =
-- VIEW -- VIEW
view : Session -> Model -> Html Msg view : Session -> Model -> { title : String, content : Html Msg }
view session model = view session model =
{ title = "Inbucket Monitor"
, content =
div [ id "page" ] div [ id "page" ]
[ h1 [] [ text "Monitor" ] [ h1 [] [ text "Monitor" ]
, p [] , p []
@@ -121,6 +118,7 @@ view session model =
, tbody [] (List.map viewMessage model.messages) , tbody [] (List.map viewMessage model.messages)
] ]
] ]
}
viewMessage : MessageHeader -> Html Msg viewMessage : MessageHeader -> Html Msg

View File

@@ -217,8 +217,10 @@ getMetrics =
-- VIEW -- -- VIEW --
view : Session -> Model -> Html Msg view : Session -> Model -> { title : String, content : Html Msg }
view session model = view session model =
{ title = "Inbucket Status"
, content =
div [ id "page" ] div [ id "page" ]
[ h1 [] [ text "Status" ] [ h1 [] [ text "Status" ]
, case model.metrics of , case model.metrics of
@@ -249,6 +251,7 @@ view session model =
] ]
] ]
] ]
}
viewMetric : Metric -> Html Msg viewMetric : Metric -> Html Msg

View File

@@ -3,7 +3,6 @@ port module Ports exposing
, monitorMessage , monitorMessage
, onSessionChange , onSessionChange
, storeSession , storeSession
, windowTitle
) )
import Data.Session exposing (Persistent) import Data.Session exposing (Persistent)
@@ -20,6 +19,3 @@ port onSessionChange : (Value -> msg) -> Sub msg
port storeSession : Persistent -> Cmd msg port storeSession : Persistent -> Cmd msg
port windowTitle : String -> Cmd msg

View File

@@ -34,8 +34,3 @@ function sessionObject() {
} }
return null return null
} }
// Window title.
app.ports.windowTitle.subscribe(function (title) {
document.title = title
})