chore: fix many cosmetic linter warnings (#486)

* fix whitespace warnings

Signed-off-by: James Hillyerd <james@hillyerd.com>

* fix a number of typos

Signed-off-by: James Hillyerd <james@hillyerd.com>

* fix many cosmetic linter warnings

Signed-off-by: James Hillyerd <james@hillyerd.com>

---------

Signed-off-by: James Hillyerd <james@hillyerd.com>

pkg/server/pop3/handler.go

@@ -463,7 +463,7 @@ func (s *Session) transactionHandler(cmd string, args []string) {
 		s.processDeletes()
 		s.enterState(QUIT)
 	case "NOOP":
-		s.send("+OK I have sucessfully done nothing")
+		s.send("+OK I have successfully done nothing")
 	case "RSET":
 		// Reset session, don't actually delete anything I told you to
 		s.logger.Debug().Msgf("Resetting session state on RSET request")

pkg/server/smtp/handler.go

@@ -206,7 +206,7 @@ func (s *Server) startSession(id int, conn net.Conn, logger zerolog.Logger) {
 					ssn.send("252 Cannot VRFY user, but will accept message")
 					continue
 				case "NOOP":
-					ssn.send("250 I have sucessfully done nothing")
+					ssn.send("250 I have successfully done nothing")
 					continue
 				case "RSET":
 					// Reset session

pkg/server/smtp/handler_test.go

@@ -222,7 +222,6 @@ func TestReadyStateRejectedDomains(t *testing.T) {
 			}
 		})
 	}
-
 }
 
 // Test invalid commands in READY state.
@@ -255,7 +254,6 @@ func TestReadyStateInvalidCommands(t *testing.T) {
 			}
 		})
 	}
-
 }
 
 // Test commands in MAIL state
@@ -562,7 +560,6 @@ func TestBeforeMailAcceptedEventResponse(t *testing.T) {
 			assert.NotNil(t, gotEvent, "BeforeMailListener did not receive Address")
 		})
 	}
-
 }
 
 // net.Pipe does not implement deadlines

pkg/server/web/server.go

@@ -51,11 +51,7 @@ type Server struct {
 }
 
 // NewServer sets up things for unit tests or the Start() method.
-func NewServer(
-	conf *config.Root,
-	mm message.Manager,
-	mh *msghub.Hub) *Server {
-
+func NewServer(conf *config.Root, mm message.Manager, mh *msghub.Hub) *Server {
 	rootConfig = conf
 
 	// NewContext() will use this DataStore for the web handlers.