Large refactor for #69

- makefile: Don't refresh deps automatically, causes double build
- storage: Move GetMessage, GetMessages (Mailbox), PurgeMessages to the
  Store API for #69
- storage: Remove Mailbox.Name method for #69
- test: Create new test package for #79
- test: Implement StoreStub, migrate some tests off MockDataStore for
  task #80
- rest & webui: update controllers to use new Store methods

pkg/server/pop3/handler.go

@@ -513,12 +513,11 @@ func (ses *Session) sendMessageTop(msg storage.Message, lineCount int) {
 
 // Load the users mailbox
 func (ses *Session) loadMailbox() {
-	var err error
-	ses.messages, err = ses.mailbox.GetMessages()
+	m, err := ses.server.dataStore.GetMessages(ses.user)
 	if err != nil {
-		ses.logError("Failed to load messages for %v", ses.user)
+		ses.logError("Failed to load messages for %v: %v", ses.user, err)
 	}
-
+	ses.messages = m
 	ses.retainAll()
 }
 

pkg/server/smtp/handler.go

@@ -478,10 +478,15 @@ func (ss *Session) deliverMessage(r recipientDetails, msgBuf [][]byte) (ok bool)
 		ss.logError("Error while closing message for %v: %v", r.mailbox, err)
 		return false
 	}
+	name, err := stringutil.ParseMailboxName(r.localPart)
+	if err != nil {
+		// This parse already succeeded when MailboxFor was called, shouldn't fail here.
+		return false
+	}
 
 	// Broadcast message information
 	broadcast := msghub.Message{
-		Mailbox: r.mailbox.Name(),
+		Mailbox: name,
 		ID:      msg.ID(),
 		From:    msg.From(),
 		To:      msg.To(),