Mirrors/go-inbucket
1
0
Fork 0
mirror of https://github.com/jhillyerd/inbucket.git synced 2025-12-18 10:07:02 +00:00
Code Issues Releases Wiki Activity

Accept and handle emails sent with an empty 821.From / return-path as… (#561)

Browse Source 
* Accept and handle emails sent with an empty 821.From / return-path as it would any other email.
This commit is contained in:
Steve Atkins
2025-03-17 15:54:30 +00:00
committed by GitHub
parent 4c8c8e7744
commit 9904399d24
3 changed files with 13 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
pkg/server/smtp/handler.go
View File

@@ -411,18 +411,6 @@ func (s *Session) parseMailFromCmd(arg string) {
from := m[1]
s.logger.Debug().Msgf("Mail sender is %v", from)
// Parse from address.
_, domain, err := policy.ParseEmailAddress(from)
s.logger.Debug().Msgf("Origin domain is %v", domain)
if from != "" && err != nil {
s.send("501 Bad sender address syntax")
s.logger.Warn().Msgf("Bad address as MAIL arg: %q, %s", from, err)
return
}
if from == "" {
from = "unspecified"
}
// Parse ESMTP parameters.
if m[2] != "" {
// Here the client may put BODY=8BITMIME, but Inbucket already
@@ -480,7 +468,7 @@ func (s *Session) parseMailFromCmd(arg string) {
// Ignore ShouldAccept if extensions explicitly allowed this From.
if extAction == event.ActionDefer && !s.from.ShouldAccept() {
s.send("501 Unauthorized domain")
s.logger.Warn().Msgf("Bad domain sender %s", domain)
s.logger.Warn().Msgf("Bad domain sender %s", origin.Domain)
return
}