Mirrors/go-inbucket
1
0
Fork 0
mirror of https://github.com/jhillyerd/inbucket.git synced 2026-01-09 20:55:56 +00:00
Code Issues Releases Wiki Activity

Take care of more TODO flagged code

Browse Source 
- Improve TODO comments, mention related issues
- Export ErrNotWritable, move it to datastore.go
- Improve logging of corrupt mailbox GOB file
This commit is contained in:
James Hillyerd
2016-02-28 16:14:37 -08:00
parent 075aa0dd38
commit 982ad857e8
6 changed files with 21 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
smtpd/handler.go
View File

@@ -413,8 +413,11 @@ func (ss *Session) dataHandler() {
for _, m := range messages {
if m != nil {
if err := m.Close(); err != nil {
// This logic should be updated to report failures
// writing the initial message file to the client
// after we implement a single-store system (issue
// #23)
ss.logError("Error: %v while writing message", err)
// TODO Report to client?
}
expReceivedTotal.Add(1)
}
@@ -437,7 +440,7 @@ func (ss *Session) dataHandler() {
ss.send("552 Maximum message size exceeded")
ss.logWarn("Max message size exceeded while in DATA")
ss.reset()
// TODO: Should really cleanup the crap on filesystem...
// Should really cleanup the crap on filesystem (after issue #23)
return
}
// Append to message objects
@@ -448,7 +451,7 @@ func (ss *Session) dataHandler() {
ss.logError("Failed to append to mailbox %v: %v", mailboxes[i], err)
ss.send("554 Something went wrong")
ss.reset()
// TODO: Should really cleanup the crap on filesystem...
// Should really cleanup the crap on filesystem (after issue #23)
return
}
}