mirror of
https://blitiri.com.ar/repos/chasquid
synced 2025-12-18 14:47:03 +00:00
9864f40f3b
We have many places in our tests where we create temporary directories, which we later remove (most of the time). We have at least 3 helpers to do this, and various places where it's done ad-hoc (and the cleanup is not always present). To try to reduce the clutter, and make the tests more uniform and readable, this patch introduces two helpers in a new "testutil" package: one for creating and one for removing temporary directories. These new functions are safer, better tested, and make the tests more consistent. All the tests are updated to use them.
55 lines
1.1 KiB
Go
55 lines
1.1 KiB
Go
package testlib
|
|
|
|
import (
|
|
"io/ioutil"
|
|
"os"
|
|
"testing"
|
|
)
|
|
|
|
func TestBasic(t *testing.T) {
|
|
dir := MustTempDir(t)
|
|
if err := ioutil.WriteFile(dir+"/file", nil, 0660); err != nil {
|
|
t.Fatalf("could not create file in %s: %v", dir, err)
|
|
}
|
|
|
|
wd, err := os.Getwd()
|
|
if err != nil {
|
|
t.Fatalf("could not get working directory: %v", err)
|
|
}
|
|
if wd != dir {
|
|
t.Errorf("MustTempDir did not change directory")
|
|
t.Errorf(" expected %q, got %q", dir, wd)
|
|
}
|
|
|
|
RemoveIfOk(t, dir)
|
|
if _, err := os.Stat(dir); !os.IsNotExist(err) {
|
|
t.Fatalf("%s existed, should have been deleted: %v", dir, err)
|
|
}
|
|
}
|
|
|
|
func TestRemoveCheck(t *testing.T) {
|
|
defer func() {
|
|
if r := recover(); r != nil {
|
|
t.Logf("recovered: %v", r)
|
|
} else {
|
|
t.Fatalf("check did not panic as expected")
|
|
}
|
|
}()
|
|
|
|
RemoveIfOk(t, "/tmp/something")
|
|
}
|
|
|
|
func TestLeaveDirOnError(t *testing.T) {
|
|
myt := &testing.T{}
|
|
dir := MustTempDir(myt)
|
|
myt.Errorf("something bad happened")
|
|
|
|
RemoveIfOk(myt, dir)
|
|
if _, err := os.Stat(dir); os.IsNotExist(err) {
|
|
t.Fatalf("%s was removed, should have been kept", dir)
|
|
}
|
|
|
|
// Remove the directory for real this time.
|
|
RemoveIfOk(t, dir)
|
|
}
|