Mirrors/go-chasquid-smtp
1
0
Fork 0
mirror of https://blitiri.com.ar/repos/chasquid synced 2025-12-17 14:37:02 +00:00
Code Releases Activity

tests: Detect buggy dkimpy versions, and skip the test if needed

Browse Source 
Some dkimpy versions have a bug where it can't parse the keys generated
by its own key generator. That causes the dkimpy test to fail.

See https://bugs.launchpad.net/dkimpy/+bug/1978835 for more details.

This patch adds a workaround which detects the buggy version, and skip
the test if needed.
This commit is contained in:
Alberto Bertogli
2022-06-19 11:54:55 +01:00
parent f303e43082
commit faadae15ca
1 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
test/t-19-dkimpy/run.sh
View File

@@ -28,6 +28,16 @@ fi
generate_certs_for testserver generate_certs_for testserver
( mkdir -p .dkimcerts; cd .dkimcerts; dknewkey private > log 2>&1 ) ( mkdir -p .dkimcerts; cd .dkimcerts; dknewkey private > log 2>&1 )
# Some dkimpy versions have a bug where it can't parse the keys generated by
# its own key generator. Detect if that's the case, and if so, skip the test.
# See https://bugs.launchpad.net/dkimpy/+bug/1978835.
if ! /usr/bin/dkimsign \
testselector1 testserver .dkimcerts/private.key \
< content 2>&1 | grep -q "DKIM-Signature:"
then
skip "buggy dkimpy version"
fi
add_user user@testserver secretpassword add_user user@testserver secretpassword
add_user someone@testserver secretpassword add_user someone@testserver secretpassword
@@ -40,7 +50,9 @@ wait_until_ready 1025
run_msmtp someone@testserver < content run_msmtp someone@testserver < content
wait_for_file .mail/someone@testserver wait_for_file .mail/someone@testserver
mail_diff content .mail/someone@testserver mail_diff content .mail/someone@testserver
grep -q "DKIM-Signature:" .mail/someone@testserver if ! grep -q "DKIM-Signature:" .mail/someone@testserver; then
fail "mail not signed, DKIM-Signature header missing"
fi
# Verify the signature manually, just in case. # Verify the signature manually, just in case.
# NOTE: This is using driusan/dkim instead of dkimpy, because dkimpy can't be # NOTE: This is using driusan/dkim instead of dkimpy, because dkimpy can't be