Mirrors/go-chasquid-smtp
1
0
Fork 0
mirror of https://blitiri.com.ar/repos/chasquid synced 2026-01-08 17:51:57 +00:00
Code Releases Activity

config: Support "" values for drop_characters and suffix_separators

Browse Source 
If the `drop_characters` or `suffix_separators` options are set to "",
currently instead of the empty string, their default value is used instead.

This is a bug, and it also happens on other config options, but because
the others have to be set in order for chasquid to function, it's not a
problem in practice.

Thanks Björn Busse (bbusse@github) for finding and reporting this
problem, on irc and in https://github.com/albertito/chasquid/issues/25.

This patch fixes the problem by marking these fields explicitly
optional, which enables presence testing, as described in the protobuf
documentation:
https://github.com/protocolbuffers/protobuf/blob/master/docs/field_presence.md.
This commit is contained in:
Alberto Bertogli
2022-01-14 01:13:31 +00:00
parent 4f595ce3d2
commit fa1db7d81a
6 changed files with 64 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
internal/config/config.proto
View File

@@ -67,13 +67,13 @@ message Config {
// Including "+" is strongly encouraged, as it is assumed for email
// forwarding.
// Default: "+".
string suffix_separators = 10;
optional string suffix_separators = 10;
// Characters to drop from the user part on local emails.
// For example, if you set this to "._", email to local user
// "u.se_r" will be delivered to "user".
// Default: ".".
string drop_characters = 11;
optional string drop_characters = 11;
// Path where to write the mail log to.
// If "<syslog>", log using the syslog (at MAIL|INFO priority).