1
0
mirror of https://blitiri.com.ar/repos/chasquid synced 2025-12-17 14:37:02 +00:00

Normalize local usernames using PRECIS

This patch implements local username normalization using PRECIS
(https://tools.ietf.org/html/rfc7564,
https://tools.ietf.org/html/rfc7613)

It makes chasquid accept local email and authentication regardless of
the case. It covers both userdb and aliases.

Note that non-local usernames remain untouched.
This commit is contained in:
Alberto Bertogli
2016-10-09 13:18:19 +01:00
parent 220b5d20ff
commit ad25706d72
8 changed files with 148 additions and 43 deletions

View File

@@ -7,8 +7,10 @@ import (
"math/rand"
"strings"
"time"
"unicode/utf8"
"golang.org/x/net/idna"
"blitiri.com.ar/go/chasquid/internal/normalize"
"blitiri.com.ar/go/chasquid/internal/userdb"
)
@@ -73,11 +75,15 @@ func DecodeResponse(response string) (user, domain, passwd string, err error) {
user = idsp[0]
domain = idsp[1]
// TODO: Quedamos aca. Validar dominio no (solo) como utf8, sino ver que
// no contenga ni "/" ni "..". Podemos usar golang.org/x/net/idna para
// convertirlo a unicode primero, o al reves. No se que queremos.
if !utf8.ValidString(user) || !utf8.ValidString(domain) {
err = fmt.Errorf("User/domain is not valid UTF-8")
// Normalize the user and domain. This is so users can write the username
// in their own style and still can log in. For the domain, we use IDNA
// to turn it to utf8 which is what we use internally.
user, err = normalize.User(user)
if err != nil {
return
}
domain, err = idna.ToUnicode(domain)
if err != nil {
return
}