Mirrors/go-chasquid-smtp
1
0
Fork 0
mirror of https://blitiri.com.ar/repos/chasquid synced 2026-10-28 15:02:28 +00:00
Code Releases Activity

test: Use modern testing features instead of custom helpers

Browse Source 
Many of our tests rely on helpers that predate features which are now
available in the standard library.

This patch replaces them with the standard equivalents:

- MustTempDir/RemoveIfOk -> t.ArtifactDir() or t.TempDir() (depending on
  whether it is useful to keep the data on request).
- GetFreePort + waitForServer -> opening the listeners before starting
  the servers. To support this, localrpc.Server gains a Serve method. We
  may re-introduce these in the future if more use cases appear.
- WaitFor and real-time timing checks -> testing/synctest.
- context.Background() -> t.Context().
- Benchmark b.N loops -> b.Loop().
- reflect.DeepEqual -> cmp.Diff, and proto.Equal for protobufs.
This commit is contained in:
Alberto Bertogli
2026-10-03 10:34:35 +01:00
parent 8d763f450d
commit 8b19760f4e
30 changed files with 495 additions and 763 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/protoio/protoio_test.go
+10 -17
View File
@@ -5,20 +5,18 @@ import (
"testing"
"blitiri.com.ar/go/chasquid/internal/protoio/testpb"
"blitiri.com.ar/go/chasquid/internal/testlib"
)
func TestBin(t *testing.T) {
dir := testlib.MustTempDir(t)
defer testlib.RemoveIfOk(t, dir)
fname := t.ArtifactDir() + "/f"
pb := &testpb.M{Content: "hola"}
if err := WriteMessage("f", pb, 0600); err != nil {
if err := WriteMessage(fname, pb, 0600); err != nil {
t.Error(err)
}
pb2 := &testpb.M{}
if err := ReadMessage("f", pb2); err != nil {
if err := ReadMessage(fname, pb2); err != nil {
t.Error(err)
}
if pb.Content != pb2.Content {
@@ -27,16 +25,15 @@ func TestBin(t *testing.T) {
}
func TestText(t *testing.T) {
dir := testlib.MustTempDir(t)
defer testlib.RemoveIfOk(t, dir)
fname := t.ArtifactDir() + "/f"
pb := &testpb.M{Content: "hola"}
if err := WriteTextMessage("f", pb, 0600); err != nil {
if err := WriteTextMessage(fname, pb, 0600); err != nil {
t.Error(err)
}
pb2 := &testpb.M{}
if err := ReadTextMessage("f", pb2); err != nil {
if err := ReadTextMessage(fname, pb2); err != nil {
t.Error(err)
}
if pb.Content != pb2.Content {
@@ -45,8 +42,7 @@ func TestText(t *testing.T) {
}
func TestStore(t *testing.T) {
dir := testlib.MustTempDir(t)
defer testlib.RemoveIfOk(t, dir)
dir := t.ArtifactDir()
st, err := NewStore(dir + "/store")
if err != nil {
t.Fatalf("failed to create store: %v", err)
@@ -98,8 +94,6 @@ func mustCreate(t *testing.T, fname string) {
}
func TestFileErrors(t *testing.T) {
dir := testlib.MustTempDir(t)
defer testlib.RemoveIfOk(t, dir)
pb := &testpb.M{Content: "hola"}
if err := WriteMessage("/proc/doesnotexist", pb, 0600); err == nil {
@@ -125,18 +119,17 @@ func TestFileErrors(t *testing.T) {
}
func TestMarshalErrors(t *testing.T) {
dir := testlib.MustTempDir(t)
defer testlib.RemoveIfOk(t, dir)
dir := t.ArtifactDir()
// The marshaller enforces that strings are well-formed utf8. So to create
// a marshalling error, we use a non-utf8 string.
pb := &testpb.M{Content: "\xc3\x28"}
if err := WriteMessage("f", pb, 0600); err == nil {
if err := WriteMessage(dir+"/f", pb, 0600); err == nil {
t.Errorf("write worked, expected error")
}
if err := WriteTextMessage("ft", pb, 0600); err == nil {
if err := WriteTextMessage(dir+"/ft", pb, 0600); err == nil {
t.Errorf("text write worked, expected error")
}
}