test: Use modern testing features instead of custom helpers

Many of our tests rely on helpers that predate features which are now
available in the standard library.

This patch replaces them with the standard equivalents:

- MustTempDir/RemoveIfOk -> t.ArtifactDir() or t.TempDir() (depending on
  whether it is useful to keep the data on request).
- GetFreePort + waitForServer -> opening the listeners before starting
  the servers. To support this, localrpc.Server gains a Serve method. We
  may re-introduce these in the future if more use cases appear.
- WaitFor and real-time timing checks -> testing/synctest.
- context.Background() -> t.Context().
- Benchmark b.N loops -> b.Loop().
- reflect.DeepEqual -> cmp.Diff, and proto.Equal for protobufs.

internal/domaininfo/domaininfo_test.go

@@ -10,8 +10,7 @@ import (
 )
 
 func TestBasic(t *testing.T) {
-	dir := testlib.MustTempDir(t)
-	defer testlib.RemoveIfOk(t, dir)
+	dir := t.ArtifactDir()
 	db, err := New(dir)
 	if err != nil {
 		t.Fatal(err)
@@ -70,8 +69,7 @@ func TestBasic(t *testing.T) {
 }
 
 func TestNewDomain(t *testing.T) {
-	dir := testlib.MustTempDir(t)
-	defer testlib.RemoveIfOk(t, dir)
+	dir := t.ArtifactDir()
 	db, err := New(dir)
 	if err != nil {
 		t.Fatal(err)
@@ -101,8 +99,7 @@ func TestNewDomain(t *testing.T) {
 }
 
 func TestProgressions(t *testing.T) {
-	dir := testlib.MustTempDir(t)
-	defer testlib.RemoveIfOk(t, dir)
+	dir := t.ArtifactDir()
 	db, err := New(dir)
 	if err != nil {
 		t.Fatal(err)
@@ -146,8 +143,7 @@ func TestErrors(t *testing.T) {
 	}
 
 	// Corrupt/invalid file.
-	dir := testlib.MustTempDir(t)
-	defer testlib.RemoveIfOk(t, dir)
+	dir := t.ArtifactDir()
 	db, err := New(dir)
 	if err != nil {
 		t.Fatal(err)
@@ -175,8 +171,7 @@ func TestErrors(t *testing.T) {
 }
 
 func TestDirectoryErrors(t *testing.T) {
-	dir := testlib.MustTempDir(t)
-	defer testlib.RemoveIfOk(t, dir)
+	dir := t.ArtifactDir()
 	db, err := New(dir + "/db")
 	if err != nil {
 		t.Fatal(err)