Mirrors/go-chasquid-smtp
1
0
Fork 0
mirror of https://blitiri.com.ar/repos/chasquid synced 2025-12-18 14:47:03 +00:00
Code Releases Activity

smtpsrv: Sanitize unknown commands

Browse Source 
Unknown commands can fill the logs, traces and expvars with a lot of
noise; this patch sanitizes them a bit down to 6 bytes, as a compromise
to maintain some information for troubleshooting.
This commit is contained in:
Alberto Bertogli
2016-10-13 20:37:29 +01:00
parent f5e466eac5
commit 88868d7d8e
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
internal/smtpsrv/conn.go
View File

@@ -147,7 +147,6 @@ loop:
break break
} }
commandCount.Add(cmd, 1)
if cmd == "AUTH" { if cmd == "AUTH" {
c.tr.Debugf("-> AUTH <redacted>") c.tr.Debugf("-> AUTH <redacted>")
} else { } else {
@@ -187,10 +186,14 @@ loop:
c.writeResponse(221, "Be seeing you...") c.writeResponse(221, "Be seeing you...")
break loop break loop
default: default:
// Sanitize it a bit to avoid filling the logs and events with
// noisy data. Keep the first 6 bytes for debugging.
cmd = fmt.Sprintf("unknown<%.6s>", cmd)
code = 500 code = 500
msg = "unknown command" msg = "unknown command"
} }
commandCount.Add(cmd, 1)
if code > 0 { if code > 0 {
c.tr.Debugf("<- %d %s", code, msg) c.tr.Debugf("<- %d %s", code, msg)