1
0
mirror of https://blitiri.com.ar/repos/chasquid synced 2025-12-22 15:27:02 +00:00

Fix non-constant format string in calls to Printf-like functions

In a few places, we call Printf-like functions, but for the format we
use either non-format messages (which is not tidy, but okay), or
variable messages (which can be problematic if they contain %-format
directives).

The patch fixes the calls by either moving to Print-like functions, or
using `Printf("%s", message)` instead.

These were found by a combination of `go vet` (which complains about
"non-constant format string in call"), and manual inspection.
This commit is contained in:
Alberto Bertogli
2025-10-24 12:34:58 +01:00
parent 3776186288
commit 5c2566c9b1
5 changed files with 14 additions and 14 deletions

View File

@@ -408,7 +408,7 @@ func TestTooMuchData(t *testing.T) {
func simpleCmd(t *testing.T, c *smtp.Client, cmd string, expected int) string {
t.Helper()
if err := c.Text.PrintfLine(cmd); err != nil {
if err := c.Text.PrintfLine("%s", cmd); err != nil {
t.Fatalf("Failed to write %s: %v", cmd, err)
}