1
0
mirror of https://blitiri.com.ar/repos/chasquid synced 2025-12-17 14:37:02 +00:00

Avoid unnecessary calls to fmt.Sprintf

The linter caught some unnecessary calls to fmt.Sprintf. This patch
removes them.

There are no functional changes.
This commit is contained in:
Alberto Bertogli
2020-04-13 13:58:31 +01:00
parent d6b512166b
commit 25ebc4f2e2
3 changed files with 5 additions and 5 deletions

View File

@@ -232,7 +232,7 @@ func (q *Queue) Remove(id string) {
func (q *Queue) DumpString() string {
q.mu.RLock()
defer q.mu.RUnlock()
s := fmt.Sprintf("# Queue status\n\n")
s := "# Queue status\n\n"
s += fmt.Sprintf("date: %v\n", time.Now())
s += fmt.Sprintf("length: %d\n\n", len(q.q))
@@ -248,7 +248,7 @@ func (q *Queue) DumpString() string {
s += fmt.Sprintf(" last failure: %q\n", rcpt.LastFailureMessage)
}
item.Unlock()
s += fmt.Sprintf("\n")
s += "\n"
}
return s

View File

@@ -74,7 +74,7 @@ func TestDSNOnTimeout(t *testing.T) {
item := &Item{
Message: Message{
ID: <-newID,
From: fmt.Sprintf("from@loco"),
From: "from@loco",
Rcpt: []*Recipient{
mkR("to@to", Recipient_EMAIL, Recipient_PENDING, "err", "to@to")},
Data: []byte("data"),
@@ -245,7 +245,7 @@ func TestSerialization(t *testing.T) {
item := &Item{
Message: Message{
ID: <-newID,
From: fmt.Sprintf("from@loco"),
From: "from@loco",
Rcpt: []*Recipient{
mkR("to@to", Recipient_EMAIL, Recipient_PENDING, "err", "to@to")},
Data: []byte("data"),

View File

@@ -606,7 +606,7 @@ func (c *Conn) DATA(params string) (code int, msg string) {
// the user keeps sending as commands, and that's a security
// issue.
readUntilDot(c.reader)
return 552, fmt.Sprintf("5.3.4 Message too big")
return 552, "5.3.4 Message too big"
}
return 554, fmt.Sprintf("5.4.0 Error reading DATA: %v", err)
}