Mirrors/go-chasquid-smtp
1
0
Fork 0
mirror of https://blitiri.com.ar/repos/chasquid synced 2025-12-18 14:47:03 +00:00
Code Releases Activity

Avoid unnecessary calls to fmt.Sprintf

Browse Source 
The linter caught some unnecessary calls to fmt.Sprintf. This patch
removes them.

There are no functional changes.
This commit is contained in:
Alberto Bertogli
2020-04-13 13:58:31 +01:00
parent d6b512166b
commit 25ebc4f2e2
3 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
internal/queue/queue.go
View File

@@ -232,7 +232,7 @@ func (q *Queue) Remove(id string) {
func (q *Queue) DumpString() string { func (q *Queue) DumpString() string {
q.mu.RLock() q.mu.RLock()
defer q.mu.RUnlock() defer q.mu.RUnlock()
s := fmt.Sprintf("# Queue status\n\n") s := "# Queue status\n\n"
s += fmt.Sprintf("date: %v\n", time.Now()) s += fmt.Sprintf("date: %v\n", time.Now())
s += fmt.Sprintf("length: %d\n\n", len(q.q)) s += fmt.Sprintf("length: %d\n\n", len(q.q))
@@ -248,7 +248,7 @@ func (q *Queue) DumpString() string {
s += fmt.Sprintf(" last failure: %q\n", rcpt.LastFailureMessage) s += fmt.Sprintf(" last failure: %q\n", rcpt.LastFailureMessage)
} }
item.Unlock() item.Unlock()
s += fmt.Sprintf("\n") s += "\n"
} }
return s return s

4
internal/queue/queue_test.go
View File

@@ -74,7 +74,7 @@ func TestDSNOnTimeout(t *testing.T) {
item := &Item{ item := &Item{
Message: Message{ Message: Message{
ID: <-newID, ID: <-newID,
From: fmt.Sprintf("from@loco"), From: "from@loco",
Rcpt: []*Recipient{ Rcpt: []*Recipient{
mkR("to@to", Recipient_EMAIL, Recipient_PENDING, "err", "to@to")}, mkR("to@to", Recipient_EMAIL, Recipient_PENDING, "err", "to@to")},
Data: []byte("data"), Data: []byte("data"),
@@ -245,7 +245,7 @@ func TestSerialization(t *testing.T) {
item := &Item{ item := &Item{
Message: Message{ Message: Message{
ID: <-newID, ID: <-newID,
From: fmt.Sprintf("from@loco"), From: "from@loco",
Rcpt: []*Recipient{ Rcpt: []*Recipient{
mkR("to@to", Recipient_EMAIL, Recipient_PENDING, "err", "to@to")}, mkR("to@to", Recipient_EMAIL, Recipient_PENDING, "err", "to@to")},
Data: []byte("data"), Data: []byte("data"),

2
internal/smtpsrv/conn.go
View File

@@ -606,7 +606,7 @@ func (c *Conn) DATA(params string) (code int, msg string) {
// the user keeps sending as commands, and that's a security // the user keeps sending as commands, and that's a security
// issue. // issue.
readUntilDot(c.reader) readUntilDot(c.reader)
return 552, fmt.Sprintf("5.3.4 Message too big") return 552, "5.3.4 Message too big"
} }
return 554, fmt.Sprintf("5.4.0 Error reading DATA: %v", err) return 554, fmt.Sprintf("5.4.0 Error reading DATA: %v", err)
} }