get rid of un-idiomatic []byte(C.GoStringN(…)) and instead use C.GoBytes()
This commit is contained in:
11
xmlsec.go
11
xmlsec.go
@@ -114,14 +114,7 @@ func dumpDoc(doc *C.xmlDoc) []byte {
|
|||||||
var buffer *C.xmlChar
|
var buffer *C.xmlChar
|
||||||
var bufferSize C.int
|
var bufferSize C.int
|
||||||
C.xmlDocDumpMemory(doc, &buffer, &bufferSize)
|
C.xmlDocDumpMemory(doc, &buffer, &bufferSize)
|
||||||
rv := C.GoStringN((*C.char)(unsafe.Pointer(buffer)), bufferSize)
|
defer C.MY_xmlFree(unsafe.Pointer(buffer))
|
||||||
C.MY_xmlFree(unsafe.Pointer(buffer))
|
|
||||||
|
|
||||||
// TODO(ross): this is totally nasty un-idiomatic, but I'm
|
return C.GoBytes(unsafe.Pointer(buffer), bufferSize)
|
||||||
// tired of googling how to copy a []byte from a char*
|
|
||||||
return []byte(rv)
|
|
||||||
}
|
|
||||||
|
|
||||||
func constXMLChar(s string) *C.xmlChar {
|
|
||||||
return (*C.xmlChar)(unsafe.Pointer(C.CString(s)))
|
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user