From a32b701d7b14ec250ab80b0e98d77ab448b8b48a Mon Sep 17 00:00:00 2001 From: Jumpei Tsuji Date: Thu, 28 Jul 2016 18:05:27 +0900 Subject: [PATCH] Removed redundant error handling --- appstore/validator.go | 6 +----- appstore/validator_test.go | 15 --------------- 2 files changed, 1 insertion(+), 20 deletions(-) diff --git a/appstore/validator.go b/appstore/validator.go index 15b00ef..83d8f0d 100644 --- a/appstore/validator.go +++ b/appstore/validator.go @@ -5,7 +5,6 @@ import ( "errors" "fmt" "os" - "strconv" "strings" "time" @@ -101,7 +100,7 @@ func NewWithConfig(config Config) Client { // Verify sends receipts and gets validation result func (c *Client) Verify(req IAPRequest) (IAPResponse, error) { result := IAPResponse{} - res, body, errs := gorequest.New(). + _, body, errs := gorequest.New(). Post(c.URL). Send(req). Timeout(c.TimeOut). @@ -110,9 +109,6 @@ func (c *Client) Verify(req IAPRequest) (IAPResponse, error) { if errs != nil { return result, fmt.Errorf("%v", errs) } - if res.StatusCode < 200 || res.StatusCode >= 300 { - return result, errors.New("An error occurred in IAP - code:" + strconv.Itoa(res.StatusCode)) - } err := json.NewDecoder(strings.NewReader(body)).Decode(&result) diff --git a/appstore/validator_test.go b/appstore/validator_test.go index e97aad4..fe28a78 100644 --- a/appstore/validator_test.go +++ b/appstore/validator_test.go @@ -146,21 +146,6 @@ func TestVerify(t *testing.T) { } } -func TestVerifyErrors(t *testing.T) { - server, client := testTools(199, "dummy response") - defer server.Close() - - req := IAPRequest{ - ReceiptData: "dummy data", - } - - expected := errors.New("An error occurred in IAP - code:199") - _, actual := client.Verify(req) - if !reflect.DeepEqual(actual, expected) { - t.Errorf("got %v\nwant %v", actual, expected) - } -} - func TestVerifyTimeout(t *testing.T) { // HTTP 100 is "continue" so it will time out server, client := testTools(100, "dummy response")