DeineAgenturUG/go-iap
1
0
Fork 0
forked from Mirrors/go-iap
Code Issues Pull Requests Releases 1 Wiki Activity

Correct tests

Browse Source 
serverWithResponse was hardcoded to return http.StatusBadRequest whereas it differed in the tests in the previous commits. This has been corrected by turning it into a parameter.
This commit is contained in:
Timothy Lock
2018-01-22 17:17:05 -05:00
parent 6d00842743
commit 594d8d6544
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
appstore/validator_test.go
View File

@@ -183,7 +183,7 @@ func TestVerifyBadURL(t *testing.T) {
} }
func TestVerifyBadPayload(t *testing.T) { func TestVerifyBadPayload(t *testing.T) {
s := httptest.NewServer(serverWithResponse(`{"status": 21002}`)) s := httptest.NewServer(serverWithResponse(http.StatusBadRequest, `{"status": 21002}`))
defer s.Close() defer s.Close()
client := New() client := New()
@@ -206,7 +206,7 @@ func TestVerifyBadPayload(t *testing.T) {
} }
func TestVerifyBadResponse(t *testing.T) { func TestVerifyBadResponse(t *testing.T) {
s := httptest.NewServer(serverWithResponse(`qwerty!@#$%^`)) s := httptest.NewServer(serverWithResponse(http.StatusInternalServerError, `qwerty!@#$%^`))
defer s.Close() defer s.Close()
client := New() client := New()
@@ -223,10 +223,10 @@ func TestVerifyBadResponse(t *testing.T) {
} }
func TestVerifySandboxReceipt(t *testing.T) { func TestVerifySandboxReceipt(t *testing.T) {
s := httptest.NewServer(serverWithResponse(`{"status": 21007}`)) s := httptest.NewServer(serverWithResponse(http.StatusOK, `{"status": 21007}`))
defer s.Close() defer s.Close()
sandboxServ := httptest.NewServer(serverWithResponse(`{"status": 0}`)) sandboxServ := httptest.NewServer(serverWithResponse(http.StatusOK, `{"status": 0}`))
defer sandboxServ.Close() defer sandboxServ.Close()
client := New() client := New()
@@ -252,7 +252,7 @@ func TestVerifySandboxReceipt(t *testing.T) {
} }
func TestVerifySandboxReceiptFailure(t *testing.T) { func TestVerifySandboxReceiptFailure(t *testing.T) {
s := httptest.NewServer(serverWithResponse(`{"status": 21007}`)) s := httptest.NewServer(serverWithResponse(http.StatusOK, `{"status": 21007}`))
defer s.Close() defer s.Close()
client := New() client := New()
@@ -295,7 +295,7 @@ func (errReader) Read(p []byte) (n int, err error) {
return 0, errors.New("test error") return 0, errors.New("test error")
} }
func serverWithResponse(response string) http.Handler { func serverWithResponse(statusCode int, response string) http.Handler {
return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
if "POST" == r.Method { if "POST" == r.Method {
w.Header().Set("Content-Type", "application/json") w.Header().Set("Content-Type", "application/json")
@@ -305,6 +305,6 @@ func serverWithResponse(response string) http.Handler {
w.Write([]byte(`unsupported request`)) w.Write([]byte(`unsupported request`))
} }
w.WriteHeader(http.StatusBadRequest) w.WriteHeader(statusCode)
}) })
} }