Support context package when requesting AppStore

This commit is contained in:
Junpei Tsuji
2018-05-17 13:37:16 +09:00
parent 79964782cf
commit 0cfabb49bb
2 changed files with 40 additions and 16 deletions

View File

@@ -2,11 +2,11 @@ package appstore
import ( import (
"bytes" "bytes"
"context"
"encoding/json" "encoding/json"
"errors" "errors"
"io/ioutil" "io/ioutil"
"net/http" "net/http"
"time"
) )
const ( const (
@@ -18,14 +18,9 @@ const (
ContentType string = "application/json; charset=utf-8" ContentType string = "application/json; charset=utf-8"
) )
// Config is a configuration to initialize client
type Config struct {
TimeOut time.Duration
}
// IAPClient is an interface to call validation API in App Store // IAPClient is an interface to call validation API in App Store
type IAPClient interface { type IAPClient interface {
Verify(IAPRequest, interface{}) error Verify(ctx context.Context, reqBody IAPRequest, resp interface{}) error
} }
// Client implements IAPClient // Client implements IAPClient
@@ -98,7 +93,7 @@ func NewWithClient(client *http.Client) *Client {
} }
// Verify sends receipts and gets validation result // Verify sends receipts and gets validation result
func (c *Client) Verify(reqBody IAPRequest, result interface{}) error { func (c *Client) Verify(ctx context.Context, reqBody IAPRequest, result interface{}) error {
b := new(bytes.Buffer) b := new(bytes.Buffer)
json.NewEncoder(b).Encode(reqBody) json.NewEncoder(b).Encode(reqBody)
@@ -107,15 +102,16 @@ func (c *Client) Verify(reqBody IAPRequest, result interface{}) error {
return err return err
} }
req.Header.Set("Content-Type", ContentType) req.Header.Set("Content-Type", ContentType)
req = req.WithContext(ctx)
resp, err := c.httpCli.Do(req) resp, err := c.httpCli.Do(req)
if err != nil { if err != nil {
return err return err
} }
defer resp.Body.Close() defer resp.Body.Close()
return c.parseResponse(resp, result, reqBody) return c.parseResponse(resp, result, ctx, reqBody)
} }
func (c *Client) parseResponse(resp *http.Response, result interface{}, reqBody IAPRequest) error { func (c *Client) parseResponse(resp *http.Response, result interface{}, ctx context.Context, reqBody IAPRequest) error {
// Read the body now so that we can unmarshal it twice // Read the body now so that we can unmarshal it twice
buf, err := ioutil.ReadAll(resp.Body) buf, err := ioutil.ReadAll(resp.Body)
if err != nil { if err != nil {
@@ -142,6 +138,7 @@ func (c *Client) parseResponse(resp *http.Response, result interface{}, reqBody
return err return err
} }
req.Header.Set("Content-Type", ContentType) req.Header.Set("Content-Type", ContentType)
req = req.WithContext(ctx)
resp, err := c.httpCli.Do(req) resp, err := c.httpCli.Do(req)
if err != nil { if err != nil {
return err return err

View File

@@ -1,6 +1,7 @@
package appstore package appstore
import ( import (
"context"
"errors" "errors"
"io/ioutil" "io/ioutil"
"net/http" "net/http"
@@ -128,10 +129,31 @@ func TestVerifyTimeout(t *testing.T) {
ReceiptData: "dummy data", ReceiptData: "dummy data",
} }
result := &IAPResponse{} result := &IAPResponse{}
err := client.Verify(req, result) ctx := context.Background()
err := client.Verify(ctx, req, result)
if err == nil { if err == nil {
t.Errorf("error should be occurred because of timeout") t.Errorf("error should be occurred because of timeout")
} }
t.Log(err)
}
func TestVerifyWithCancel(t *testing.T) {
client := New()
req := IAPRequest{
ReceiptData: "dummy data",
}
result := &IAPResponse{}
ctx, cancelFunc := context.WithCancel(context.Background())
go func() {
time.Sleep(10 * time.Millisecond)
cancelFunc()
}()
err := client.Verify(ctx, req, result)
if err == nil {
t.Errorf("error should be occurred because of context cancel")
}
t.Log(err)
} }
func TestVerifyBadURL(t *testing.T) { func TestVerifyBadURL(t *testing.T) {
@@ -142,7 +164,8 @@ func TestVerifyBadURL(t *testing.T) {
ReceiptData: "dummy data", ReceiptData: "dummy data",
} }
result := &IAPResponse{} result := &IAPResponse{}
err := client.Verify(req, result) ctx := context.Background()
err := client.Verify(ctx, req, result)
if err == nil { if err == nil {
t.Errorf("error should be occurred because the server is not real") t.Errorf("error should be occurred because the server is not real")
} }
@@ -195,7 +218,8 @@ func TestResponses(t *testing.T) {
client.SandboxURL = tc.sandboxServ.URL client.SandboxURL = tc.sandboxServ.URL
} }
err := client.Verify(req, result) ctx := context.Background()
err := client.Verify(ctx, req, result)
if err != nil { if err != nil {
t.Errorf("Test case %d - %s", i, err.Error()) t.Errorf("Test case %d - %s", i, err.Error())
} }
@@ -233,7 +257,8 @@ func TestErrors(t *testing.T) {
defer tc.testServer.Close() defer tc.testServer.Close()
client.ProductionURL = tc.testServer.URL client.ProductionURL = tc.testServer.URL
err := client.Verify(req, result) ctx := context.Background()
err := client.Verify(ctx, req, result)
if err == nil { if err == nil {
t.Errorf("Test case %d - expected error to be not nil since the sandbox is not responding", i) t.Errorf("Test case %d - expected error to be not nil since the sandbox is not responding", i)
} }
@@ -244,7 +269,8 @@ func TestCannotReadBody(t *testing.T) {
client := New() client := New()
testResponse := http.Response{Body: ioutil.NopCloser(errReader(0))} testResponse := http.Response{Body: ioutil.NopCloser(errReader(0))}
if client.parseResponse(&testResponse, IAPResponse{}, IAPRequest{}) == nil { ctx := context.Background()
if client.parseResponse(&testResponse, IAPResponse{}, ctx, IAPRequest{}) == nil {
t.Errorf("expected redirectToSandbox to fail to read the body") t.Errorf("expected redirectToSandbox to fail to read the body")
} }
} }
@@ -253,7 +279,8 @@ func TestCannotUnmarshalBody(t *testing.T) {
client := New() client := New()
testResponse := http.Response{Body: ioutil.NopCloser(strings.NewReader(`{"status": true}`))} testResponse := http.Response{Body: ioutil.NopCloser(strings.NewReader(`{"status": true}`))}
if client.parseResponse(&testResponse, StatusResponse{}, IAPRequest{}) == nil { ctx := context.Background()
if client.parseResponse(&testResponse, StatusResponse{}, ctx, IAPRequest{}) == nil {
t.Errorf("expected redirectToSandbox to fail to unmarshal the data") t.Errorf("expected redirectToSandbox to fail to unmarshal the data")
} }
} }